DM-50717: Run background subtraction in detectAndMeasure#397
Merged
Conversation
leeskelvin
approved these changes
May 11, 2025
| ) | ||
| subtractFinalBackground = pexConfig.ConfigurableField( | ||
| target=lsst.meas.algorithms.SubtractBackgroundTask, | ||
| doc="Task to perform intial background subtraction, after first detection pass.", |
Contributor
There was a problem hiding this comment.
Should this be Task to perform final background subtraction, ...?
|
|
||
| if self.config.doSubtractBackground: | ||
| # Run background subtraction again after detecting peaks | ||
| # but before measurement |
Contributor
There was a problem hiding this comment.
extra whitespace in doc string.
isullivan
force-pushed
the
tickets/DM-50717
branch
from
9860488 to
4f4dc42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves background subtraction out of
subtractImageswhere it was previously done as part of the psf matching kernel fit, and into a subtask indetectAndMeasure.